Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifts and unshifts of concepts around sequential colimits #1070

Merged
merged 14 commits into from
Apr 10, 2024

Conversation

VojtechStep
Copy link
Collaborator

@VojtechStep VojtechStep commented Mar 12, 2024

This PR formalizes shifts of sequential diagrams, morphisms of sequential diagrams, cocones of sequential diagrams, homotopies of cocones of sequential diagrams, and unshifts of the last two. This machinery is used to show that dropping any finite number of vertices from the beginning of a sequential diagram gives an equivalent sequential colimit.

It also adds a page for the formalization of the paper, with references to the formalized parts. See the attached screenshot.
20240315 175417 screen

The formalization page has a lot of TODOs left, which I am planning to formalize in the future #1080.

@fredrik-bakke fredrik-bakke added documentation Improvements or additions to documentation synthetic-homotopy-theory labels Mar 12, 2024
@VojtechStep VojtechStep changed the title Formalize the rest of SDR20 Shifts and unshifts of concepts around sequential colimits Mar 15, 2024
@VojtechStep VojtechStep marked this pull request as ready for review March 15, 2024 17:10
@VojtechStep
Copy link
Collaborator Author

I made the scope of this PR smaller so that we could potentially merge it sooner. I'm marking it ready for review.

book.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a preliminary review. I did not look closer at the prose in the SRD20 module, and did not look at the formalization of shifts

src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
src/papers/SDR20.lagda.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments :) (still an incomplete review)

@VojtechStep
Copy link
Collaborator Author

@EgbertRijke could I eventually get your input, mainly on the organization of the Papers section? Not to discourage you from looking at the rest of the PR.

@EgbertRijke
Copy link
Collaborator

@EgbertRijke could I eventually get your input, mainly on the organization of the Papers section? Not to discourage you from looking at the rest of the PR.

Yep! Tonight I have other plans, but I will have a look over the weekend.

@fredrik-bakke
Copy link
Collaborator

fredrik-bakke commented Apr 6, 2024

Although I would like to have this PR merged soon, I feel uneasy about merging this before we decide on the proper way to name the papers files, as otherwise, the credit to the original author of the file may be lost on potential subsequent renamings. Can we perhaps factor out the papers addition into a separate PR?

@VojtechStep
Copy link
Collaborator Author

I agree; on it

@VojtechStep VojtechStep merged commit 20569c1 into UniMath:master Apr 10, 2024
4 checks passed
@VojtechStep VojtechStep deleted the feature/sequential-colimits branch April 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation synthetic-homotopy-theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants